Fixing variable name typo ('Parition' -> Partition).

content/browser/browser_context.cc

Index: content/browser/browser_context.cc
diff --git a/content/browser/browser_context.cc b/content/browser/browser_context.cc
index 25ffaf2d835cb527c2b10d10cb43f773d4283433..825982ce130e3ae17f7e3bceaef8ff5036136151 100644
--- a/content/browser/browser_context.cc
+++ b/content/browser/browser_context.cc
@@ -36,20 +36,16 @@ namespace {
 
 // Key names on BrowserContext.
 const char kDownloadManagerKeyName[] = "download_manager";
-const char kStorageParitionMapKeyName[] = "content_storage_partition_map";
-
-#if defined(OS_CHROMEOS)
-const char kMountPointsKey[] = "mount_points";
-#endif  // defined(OS_CHROMEOS)
+const char kStoragePartitionMapKeyName[] = "content_storage_partition_map";
 
 StoragePartitionImplMap* GetStoragePartitionMap(
     BrowserContext* browser_context) {
   StoragePartitionImplMap* partition_map =
       static_cast<StoragePartitionImplMap*>(
-          browser_context->GetUserData(kStorageParitionMapKeyName));
+          browser_context->GetUserData(kStoragePartitionMapKeyName));
   if (!partition_map) {
     partition_map = new StoragePartitionImplMap(browser_context);
-    browser_context->SetUserData(kStorageParitionMapKeyName, partition_map);
+    browser_context->SetUserData(kStoragePartitionMapKeyName, partition_map);
   }
   return partition_map;
 }
@@ -145,6 +141,7 @@ storage::ExternalMountPoints* BrowserContext::GetMountPoints(
          !BrowserThread::IsMessageLoopValid(BrowserThread::UI));
 
 #if defined(OS_CHROMEOS)
+  const char kMountPointsKey[] = "mount_points";

[davidben, 2015/08/14 21:18:34]

This miiiiight accidentally work, but only because the compiler will likely
allocate the string literal in .rodata rather than put it on stack or something.

GetUserData requires that the value be the same each time. In fact, the string
is irrelevant and is mostly a debugging aid I think? (Actually I think we
usually use a slightly different pattern these days since the compiler might try
to globally deduplicate string pointers across compilation units?)

Anyway, it's the value of the pointer that's significant, not the string, and
that value needs to be the same across calls. Let's just put that back. If we
want it revised further, we'll do a separate CL.

   if (!context->GetUserData(kMountPointsKey)) {
     scoped_refptr<storage::ExternalMountPoints> mount_points =
         storage::ExternalMountPoints::CreateRefCounted();
@@ -199,7 +196,7 @@ void BrowserContext::ForEachStoragePartition(
     const StoragePartitionCallback& callback) {
   StoragePartitionImplMap* partition_map =
       static_cast<StoragePartitionImplMap*>(
-          browser_context->GetUserData(kStorageParitionMapKeyName));
+          browser_context->GetUserData(kStoragePartitionMapKeyName));
   if (!partition_map)
     return;