NOT FOR REVIEW: Aura on Android - content shell compiles

ui/aura/window_tree_host_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_AURA_WINDOW_TREE_HOST_OZONE_H_
 #define UI_AURA_WINDOW_TREE_HOST_OZONE_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/platform_window/platform_window_delegate.h"
 
 namespace ui {
 class PlatformWindow;
 }
 
 namespace aura {
 
-class AURA_EXPORT WindowTreeHostOzone : public WindowTreeHost,
-                                        public ui::PlatformWindowDelegate {
+class AURA_EXPORT WindowTreeHostAndroid : public WindowTreeHost,
+                                          public ui::PlatformWindowDelegate {
  public:
-  explicit WindowTreeHostOzone(const gfx::Rect& bounds);
-  ~WindowTreeHostOzone() override;
+  explicit WindowTreeHostAndroid(const gfx::Rect& bounds);
+  ~WindowTreeHostAndroid() override;
 
  protected:
   // WindowTreeHost:
   ui::EventSource* GetEventSource() override;
   gfx::AcceleratedWidget GetAcceleratedWidget() override;
   void ShowImpl() override;
   void HideImpl() override;
   gfx::Rect GetBounds() const override;
   void SetBounds(const gfx::Rect& bounds) override;
   gfx::Point GetLocationOnNativeScreen() const override;
@@ skipping 20 matching lines @@
 
   // Platform-specific part of this WindowTreeHost.
   scoped_ptr<ui::PlatformWindow> platform_window_;
 
   // The identifier used to create a compositing surface.
   gfx::AcceleratedWidget widget_;
 
   // Current Aura cursor.
   gfx::NativeCursor current_cursor_;
 
-  DISALLOW_COPY_AND_ASSIGN(WindowTreeHostOzone);
+  DISALLOW_COPY_AND_ASSIGN(WindowTreeHostAndroid);

[sadrul, 2015/08/13 18:31:28]

We should, of course, have a single WindowTreeHostCommon implementation that
uses a PlatformWindow (instead of three for ozone, win, and android).

[mfomitchev, 2015/08/13 21:08:23]

Oh yeah, for sure. The only real difference between WTHAndroid and WTHOzone is
the constructor, and it seems WindowTreeHostWin is pretty similar as well. Do
you suggest we put it all in the same .cc file and just ifdef differing pieces?

[sadrul, 2015/08/13 21:33:20]

I think so, yeah. I played with the idea of introducing a PlatformWindowFactory
a long while back (https://codereview.chromium.org/403263002/), but we currently
do #ifdefs for view_manager
(https://code.google.com/p/chromium/codesearch#chromium/src/components/view_ma...).
We can do similar things here too.

 };
 
 }  // namespace aura
 
 #endif  // UI_AURA_WINDOW_TREE_HOST_OZONE_H_