Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284313002: Assert should not be reached failure in fontWeightIsBold (Closed)

Created:
5 years, 4 months ago by rwlbuis
Modified:
5 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Assert should not be reached failure in fontWeightIsBold While fontWeight was protected using !fontWeightNeedsResolving in order to not call fontWeightIsBold for lighter/bolder, baseFontWeight was not, so add that logic. BUG=518572 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200659

Patch Set 1 #

Patch Set 2 : V2 #

Total comments: 2

Patch Set 3 : Use testharness.js #

Total comments: 2

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
A LayoutTests/editing/pasteboard/insert-font-weight2.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
rwlbuis
PTAL
5 years, 4 months ago (2015-08-12 23:08:06 UTC) #4
yosin_UTC9
C++ code change looks good. https://codereview.chromium.org/1284313002/diff/60001/LayoutTests/editing/pasteboard/insert-font-weight2.html File LayoutTests/editing/pasteboard/insert-font-weight2.html (right): https://codereview.chromium.org/1284313002/diff/60001/LayoutTests/editing/pasteboard/insert-font-weight2.html#newcode1 LayoutTests/editing/pasteboard/insert-font-weight2.html:1: <!DOCTYPE html> Could you ...
5 years, 4 months ago (2015-08-13 00:58:16 UTC) #5
yosin_UTC9
https://codereview.chromium.org/1284313002/diff/60001/Source/core/editing/EditingStyle.cpp File Source/core/editing/EditingStyle.cpp (right): https://codereview.chromium.org/1284313002/diff/60001/Source/core/editing/EditingStyle.cpp#newcode1632 Source/core/editing/EditingStyle.cpp:1632: if (!fontWeightNeedsResolving(fontWeight.get()) && !fontWeightNeedsResolving(baseFontWeight.get()) Can we move |fontWegithNeedsResolving()| into ...
5 years, 4 months ago (2015-08-13 01:01:14 UTC) #6
rwlbuis
On 2015/08/13 01:01:14, Yosi_UTC9 wrote: > https://codereview.chromium.org/1284313002/diff/60001/Source/core/editing/EditingStyle.cpp > File Source/core/editing/EditingStyle.cpp (right): > > https://codereview.chromium.org/1284313002/diff/60001/Source/core/editing/EditingStyle.cpp#newcode1632 > ...
5 years, 4 months ago (2015-08-13 14:16:07 UTC) #7
yosin_UTC9
On 2015/08/13 14:16:07, rwlbuis wrote: > On 2015/08/13 01:01:14, Yosi_UTC9 wrote: > > > https://codereview.chromium.org/1284313002/diff/60001/Source/core/editing/EditingStyle.cpp ...
5 years, 4 months ago (2015-08-14 06:13:45 UTC) #8
rwlbuis
On 2015/08/14 06:13:45, Yosi_UTC9 wrote: > On 2015/08/13 14:16:07, rwlbuis wrote: > > On 2015/08/13 ...
5 years, 4 months ago (2015-08-14 10:24:25 UTC) #9
yosin_UTC9
Oops, sorry I forgot to send... https://codereview.chromium.org/1284313002/diff/80001/LayoutTests/editing/pasteboard/insert-font-weight2.html File LayoutTests/editing/pasteboard/insert-font-weight2.html (right): https://codereview.chromium.org/1284313002/diff/80001/LayoutTests/editing/pasteboard/insert-font-weight2.html#newcode20 LayoutTests/editing/pasteboard/insert-font-weight2.html:20: document.execCommand("selectAll", false, null); ...
5 years, 4 months ago (2015-08-15 07:00:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284313002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284313002/100001
5 years, 4 months ago (2015-08-17 14:13:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94027)
5 years, 4 months ago (2015-08-17 17:40:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284313002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284313002/100001
5 years, 4 months ago (2015-08-17 18:11:23 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 18:56:04 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200659

Powered by Google App Engine
This is Rietveld 408576698