chrome/test/data/extensions/subscribe_page_action/feed_finder.js - Issue 12843037: Convert the RSS extension to event pages to avoid a dedicated background process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/subscribe_page_action/feed_finder.js

Issue 12843037: Convert the RSS extension to event pages to avoid a dedicated background process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/subscribe_page_action/doc_start.js ('k') | chrome/test/data/extensions/subscribe_page_action/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/subscribe_page_action/feed_finder.js

===================================================================

--- chrome/test/data/extensions/subscribe_page_action/feed_finder.js (revision 192805)

+++ chrome/test/data/extensions/subscribe_page_action/feed_finder.js (working copy)

@@ -33,7 +33,7 @@

if (count > 0) {

// Notify the extension needs to show the RSS page action icon.

- chrome.extension.sendRequest({msg: "feedIcon", feeds: feeds});

+ chrome.extension.sendMessage({msg: "feedIcon", feeds: feeds});

}

@@ -57,7 +57,7 @@

if (soleTagInBody == "RSS" || soleTagInBody == "FEED" ||

soleTagInBody == "RDF") {

debugMsg(logLevels.info, "Found feed: Tag is: " + soleTagInBody);

- chrome.extension.sendRequest({msg: "feedDocument", href: location.href});

+ chrome.extension.sendMessage({msg: "feedDocument", href: location.href});

return true;

}

@@ -79,7 +79,7 @@

// |doc| now contains the parsed document within the PRE tag.

if (containsFeed(doc)) {

// Let the extension know that we should show the subscribe page.

- chrome.extension.sendRequest({msg: "feedDocument", href: location.href});

+ chrome.extension.sendMessage({msg: "feedDocument", href: location.href});

return true;

}