Keyboard accessory tools on the right side.

Keyboard accessory tools on the right side.

The tools at the end of the keyboard accessory (settings and scan card)
stick to the edge of the screen when the suggestion don't fill the
entire screen. This is accomplished via a 0x0 view with gravity 1
inserted between the tools and the suggestions.

BUG=428087
Committed: https://crrev.com/543369854a9936c6e8272d92d0857c8cf4aef1c9
Cr-Commit-Position: refs/heads/master@{#343941}

[please use gerrit instead, 2015-08-17 18:43:41]

rouslan@chromium.org changed reviewers:
+ aurimas@chromium.org

[please use gerrit instead, 2015-08-17 18:43:42]

Aurimas, PTAL Patch Set 1.

[please use gerrit instead, 2015-08-17 18:44:33]

rouslan@chromium.org changed reviewers:
+ newt@chromium.org
- aurimas@chromium.org

[please use gerrit instead, 2015-08-17 18:44:33]

Newton, PTAL Patch Set 1.

(Aurimas is still on vacation today.)

[please use gerrit instead, 2015-08-17 18:45:11]

Screenshot @ http://crbug.com/428087#c39

[newt (away), 2015-08-17 19:55:30]

https://codereview.chromium.org/1284303004/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java
(right):

https://codereview.chromium.org/1284303004/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java:130:
public void showWithSuggestions(AutofillSuggestion[] suggestions, boolean isRtl)
{
How about adding all the views in order (with a simple for loop), and then
inserting the separator view at the desired position at the end? That seems much
simpler than the logic below.

https://codereview.chromium.org/1284303004/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java:134:
if (suggestions[i].getSuggestionId() >= 0) {
This line is magical. What does a positive suggestion ID signify?

(I half-way know, but only because you mentioned it elsewhere earlier today)

[please use gerrit instead, 2015-08-17 22:30:01]

Newton, PTAL Patch Set 2.

https://codereview.chromium.org/1284303004/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java
(right):

https://codereview.chromium.org/1284303004/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java:130:
public void showWithSuggestions(AutofillSuggestion[] suggestions, boolean isRtl)
{
On 2015/08/17 19:55:30, newt wrote:
> How about adding all the views in order (with a simple for loop), and then
> inserting the separator view at the desired position at the end? That seems
much
> simpler than the logic below.

Done using boolean variable named "previousItemIsSuggestion", which is confusing
given "AutofillSuggestion" array of "suggestions". Can you think of a better
name?..

https://codereview.chromium.org/1284303004/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java:134:
if (suggestions[i].getSuggestionId() >= 0) {
On 2015/08/17 19:55:30, newt wrote:
> This line is magical. What does a positive suggestion ID signify?
> 
> (I half-way know, but only because you mentioned it elsewhere earlier today)

Commented.

[newt (away), 2015-08-17 23:33:36]

https://codereview.chromium.org/1284303004/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java
(right):

https://codereview.chromium.org/1284303004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java:70:
boolean previousItemIsSuggestion = false;
How about

  int separatorPosition = -1;

  for ...

    if (suggestion.getSuggestionId() < 0 && suggestion.getIconId() != 0) {
      if (separatorPosition == -1) separatorPosition = getChildCount();
      ...
    }

  ...

  View separator = new View(getContext());
  addView(separator, separatorPosition);

[please use gerrit instead, 2015-08-18 00:33:11]

Newton, PTAL Patch Set 3.

https://codereview.chromium.org/1284303004/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java
(right):

https://codereview.chromium.org/1284303004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java:70:
boolean previousItemIsSuggestion = false;
On 2015/08/17 23:33:36, newt wrote:
> How about
> 
>   int separatorPosition = -1;
> 
>   for ...
> 
>     if (suggestion.getSuggestionId() < 0 && suggestion.getIconId() != 0) {
>       if (separatorPosition == -1) separatorPosition = getChildCount();
>       ...
>     }
> 
>   ...
> 
>   View separator = new View(getContext());
>   addView(separator, separatorPosition);

Done, although I have to check for "separatorPosition != -1" before adding the
separator, because autocomplete suggestions do not have a link to autofill
settings.

Autocomplete suggestions are single-field suggestions that do not correspond to
profiles or credit cards. Autofill settings do not show autocomplete
suggestions, so showing a "settings" icon would be confusing. This is existing
behavior.

[newt (away), 2015-08-18 00:39:05]

lgtm

[please use gerrit instead, 2015-08-18 16:41:30]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-08-18 16:41:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284303004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284303004/40001

[commit-bot: I haz the power, 2015-08-18 16:47:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-18 16:47:44]

Patchset 3 (id:??) landed as
https://crrev.com/543369854a9936c6e8272d92d0857c8cf4aef1c9
Cr-Commit-Position: refs/heads/master@{#343941}