Replace screen capture confirmation infobar with a message box.

chrome/browser/ui/screen_capture_confirmation_dialog.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/screen_capture_confirmation_dialog.h"
+
+#include "base/logging.h"
+#include "chrome/browser/ui/simple_message_box.h"
+#include "content/public/browser/browser_thread.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+ScreenCaptureConfirmationDialog::ScreenCaptureConfirmationDialog()
+    : weak_factory_(this) {
+}
+
+ScreenCaptureConfirmationDialog::~ScreenCaptureConfirmationDialog() {
+}
+
+bool ScreenCaptureConfirmationDialog::Show(
+    const ResultCallback& result_callback,
+    const string16& application_name) {
+  result_callback_ = result_callback;
+  application_name_ = application_name;

[Peter Kasting, 2013/03/22 22:48:30]

If you pass these to ShowMessageBox(), you need not keep them as members.

At that point, ScreenCaptureConfirmationDialog can disappear entirely and
ShowMessageBox() can simply become a private function on
MediaCaptureDevicesDispatcher, simplifying this change significantly further.

[Sergey Ulanov, 2013/03/22 23:26:09]

Done.
That's not the direction I want this code to move. We will need to modify this
UI - I don't think we want to use ShowMessageBox() in long term.

+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&ScreenCaptureConfirmationDialog::ShowMessageBox,
+                 weak_factory_.GetWeakPtr()));
+  return true;
+}
+
+void ScreenCaptureConfirmationDialog::ShowMessageBox() {
+  chrome::MessageBoxResult result = chrome::ShowMessageBox(
+      NULL,
+      l10n_util::GetStringFUTF16(IDS_MEDIA_SCREEN_CAPTURE_CONFIRMATION_TITLE,
+                                 application_name_),
+      l10n_util::GetStringFUTF16(IDS_MEDIA_SCREEN_CAPTURE_CONFIRMATION_TEXT,
+                                 application_name_),
+      chrome::MESSAGE_BOX_TYPE_QUESTION);
+  ResultCallback callback = result_callback_;
+  result_callback_.Reset();
+  callback.Run(result == chrome::MESSAGE_BOX_RESULT_YES ? ALLOW : DENY);
+}