Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 12843006: Use llvm-opt's LTO pass list instead of generic O2/O3 pass list for LTO (Closed)

Created:
7 years, 9 months ago by Derek Schuff
Modified:
7 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Use llvm-opt's LTO pass list instead of generic O2/O3 pass list for LTO This reduces pnacl's link time significantly at basically no cost in runtime* *(I ran SPEC, and a couple of benchmarks were a bit slower, but most were the same or faster. Unfortunately we have no good way to get a better measurement other than committing and rolling DEPS) R=jvoung@chromium.org BUG= Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11070

Patch Set 1 #

Patch Set 2 : link dwarf test with O0 #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M pnacl/build.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M pnacl/driver/pnacl-ld.py View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M tests/toolchain/nacl.scons View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Derek Schuff
7 years, 9 months ago (2013-03-20 01:10:48 UTC) #1
jvoung - send to chromium...
On 2013/03/20 01:10:48, Derek Schuff wrote: You might have to make sure dwarf_local_var_nexe built with ...
7 years, 9 months ago (2013-03-20 16:36:23 UTC) #2
Derek Schuff
On 2013/03/20 16:36:23, jvoung wrote: > On 2013/03/20 01:10:48, Derek Schuff wrote: > > You ...
7 years, 9 months ago (2013-03-21 20:54:51 UTC) #3
jvoung - send to chromium...
lgtm https://codereview.chromium.org/12843006/diff/8001/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/12843006/diff/8001/pnacl/driver/pnacl-ld.py#newcode44 pnacl/driver/pnacl-ld.py:44: 'OPT_FLAGS': '${#OPT_LEVEL && !OPT_LEVEL == 0 ? ${OPT_LTO_FLAGS}} ...
7 years, 9 months ago (2013-03-21 21:17:05 UTC) #4
jvoung - send to chromium...
https://codereview.chromium.org/12843006/diff/8001/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/12843006/diff/8001/pnacl/driver/pnacl-ld.py#newcode43 pnacl/driver/pnacl-ld.py:43: 'OPT_LTO_FLAGS': '-std-link-opts -disable-internalize', might also want to leave a ...
7 years, 9 months ago (2013-03-21 21:23:37 UTC) #5
Derek Schuff
7 years, 9 months ago (2013-03-26 23:19:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r11070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698