Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1284283003: [CacheStorage] Use appopriate type parameters for WebCallbacks (2/3). (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 4 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Use appopriate type parameters for WebCallbacks (2/3). This series of CLs fixes WebCallback parameter types used in CacheStorage. - WebServiceWorkerResponse* (ownership not transferred) => const WebServiceWorkerResponse& - WebVector<WebServiceWorkerResponse>* (ownership not transferred) => const WebVector<WebServiceWorkerResponse>& - WebVector<WebServiceWorkerRequest>* (ownership not transferred) => const WebVector<WebServiceWorkerRequest>& - WebServiceWorkerCache* (ownership transferred) => WebPassOwnPtr<WebServiceWorkerCache> - WebVector<WebString>* (ownership not transferred) => const WebVector<WebString>& - WebServiceWorkerCacheError* (ownership transferred) => WebServiceWorkerCacheError 1/3: https://codereview.chromium.org/1284173004/ 2/3: https://codereview.chromium.org/1284283003/ 3/3: https://codereview.chromium.org/1296723005/ BUG=493531 Committed: https://crrev.com/ab0af9a5611ac80eed35771b5f9bf169d63dbe4e Cr-Commit-Position: refs/heads/master@{#344437}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M content/renderer/cache_storage/cache_storage_dispatcher.cc View 1 16 chunks +19 lines, -35 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
yhirano
5 years, 4 months ago (2015-08-19 10:27:15 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/1284283003/diff/1/content/renderer/cache_storage/cache_storage_dispatcher.cc File content/renderer/cache_storage/cache_storage_dispatcher.cc (right): https://codereview.chromium.org/1284283003/diff/1/content/renderer/cache_storage/cache_storage_dispatcher.cc#newcode132 content/renderer/cache_storage/cache_storage_dispatcher.cc:132: blink::WebServiceWorkerCacheErrorNotFound)); onError(blink::WebServiceWorkerCacheErrorNotFound) ?
5 years, 4 months ago (2015-08-19 11:29:43 UTC) #3
yhirano
https://codereview.chromium.org/1284283003/diff/1/content/renderer/cache_storage/cache_storage_dispatcher.cc File content/renderer/cache_storage/cache_storage_dispatcher.cc (right): https://codereview.chromium.org/1284283003/diff/1/content/renderer/cache_storage/cache_storage_dispatcher.cc#newcode132 content/renderer/cache_storage/cache_storage_dispatcher.cc:132: blink::WebServiceWorkerCacheErrorNotFound)); On 2015/08/19 11:29:42, nhiroki wrote: > onError(blink::WebServiceWorkerCacheErrorNotFound) ? ...
5 years, 4 months ago (2015-08-19 11:39:41 UTC) #4
yhirano
5 years, 4 months ago (2015-08-19 11:39:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284283003/20001
5 years, 4 months ago (2015-08-20 02:15:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22099)
5 years, 4 months ago (2015-08-20 03:07:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284283003/20001
5 years, 4 months ago (2015-08-20 03:42:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22125)
5 years, 4 months ago (2015-08-20 04:17:03 UTC) #14
nhiroki
On 2015/08/20 04:17:03, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-08-20 04:36:54 UTC) #15
yhirano
On 2015/08/20 04:36:54, nhiroki wrote: > On 2015/08/20 04:17:03, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-08-20 05:18:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284283003/20001
5 years, 4 months ago (2015-08-20 05:48:17 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 06:40:03 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 06:40:35 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab0af9a5611ac80eed35771b5f9bf169d63dbe4e
Cr-Commit-Position: refs/heads/master@{#344437}

Powered by Google App Engine
This is Rietveld 408576698