Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284283002: [Android] Add partial output to TimeoutError raised in cmd_helper. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
sullivan
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add partial output to TimeoutError raised in cmd_helper. BUG= Committed: https://crrev.com/807c4b377bbf6945949755da93709fd136eb1f3e Cr-Commit-Position: refs/heads/master@{#343059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M build/android/pylib/cmd_helper.py View 3 chunks +17 lines, -6 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
This should at least handle output when tests time out, e.g. http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/5319/steps/text_selection.character/logs/stdio
5 years, 4 months ago (2015-08-12 16:19:53 UTC) #2
sullivan
lgtm
5 years, 4 months ago (2015-08-12 16:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284283002/1
5 years, 4 months ago (2015-08-12 16:56:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 18:29:04 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:29:44 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/807c4b377bbf6945949755da93709fd136eb1f3e
Cr-Commit-Position: refs/heads/master@{#343059}

Powered by Google App Engine
This is Rietveld 408576698