Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp - Issue 1284203004: Generate scroll/clip display item hierarchy for SPv2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp

Issue 1284203004: Generate scroll/clip display item hierarchy for SPv2 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix assertion failure Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/LayerDescendantClipRecorder.h ('K') | « Source/platform/graphics/paint/FixedPositionContainerDisplayItem.h ('k') | Source/platform/graphics/paint/FixedPositionDisplayItem.h » ('j') | Source/platform/graphics/paint/FixedPositionDisplayItem.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp

diff --git a/Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp b/Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp

index a0c5b82118f6ef98785d7475088c9ba90351eab9..41f97c8f8a3eaf3b3e0513ab8b3481be0295c18d 100644

--- a/Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp

+++ b/Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp

@@ -11,12 +11,7 @@

namespace blink {

-void BeginFixedPositionContainerDisplayItem::appendToWebDisplayItemList(WebDisplayItemList* list) const

- // TODO(trchen): Should implement the compositor counterpart and update transform tree algorithm.

-void EndFixedPositionContainerDisplayItem::appendToWebDisplayItemList(WebDisplayItemList* list) const

+void FixedPositionContainerDisplayItem::appendToWebDisplayItemList(WebDisplayItemList* list) const

{

// TODO(trchen): Should implement the compositor counterpart and update transform tree algorithm.

}