Source/core/paint/FilterPainter.cpp - Issue 1284203004: Generate scroll/clip display item hierarchy for SPv2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/FilterPainter.cpp

Issue 1284203004: Generate scroll/clip display item hierarchy for SPv2 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix assertion failure Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/DisplayItemListPaintTest.cpp ('K') | « Source/core/paint/DisplayItemListPaintTest.cpp ('k') | Source/core/paint/LayerClipRecorder.cpp » ('j') | Source/core/paint/LayerDescendantClipRecorder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/FilterPainter.cpp

diff --git a/Source/core/paint/FilterPainter.cpp b/Source/core/paint/FilterPainter.cpp

index 309a8a2cbe9278beab4eef2ec09d513a91f80134..52bf8702e01081d5afb39f47b467e58e07fbb56c 100644

--- a/Source/core/paint/FilterPainter.cpp

+++ b/Source/core/paint/FilterPainter.cpp

@@ -52,7 +52,7 @@ FilterPainter::FilterPainter(DeprecatedPaintLayer& layer, GraphicsContext* conte

// done it above, and doing it later will defeat the outsets.

paintingInfo.clipToDirtyRect = false;

- if (clipRect.rect() != paintingInfo.paintDirtyRect || clipRect.hasRadius()) {

+ if ((clipRect.rect() != paintingInfo.paintDirtyRect || clipRect.hasRadius()) && !RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

m_clipRecorder = adoptPtr(new LayerClipRecorder(*context, *layer.layoutObject(), DisplayItem::ClipLayerFilter, clipRect, &paintingInfo, LayoutPoint(), paintFlags));

}