Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: Source/modules/cachestorage/CacheTest.cpp

Issue 1284173004: [CacheStorage] Use appopriate type parameters for WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/cachestorage/CacheTest.cpp
diff --git a/Source/modules/cachestorage/CacheTest.cpp b/Source/modules/cachestorage/CacheTest.cpp
index e0b8a74afecb8d19994e3302bd1860ef69e11b34..48011811d557eafebd9d3a61cad7e53bf1853ca5 100644
--- a/Source/modules/cachestorage/CacheTest.cpp
+++ b/Source/modules/cachestorage/CacheTest.cpp
@@ -112,7 +112,7 @@ public:
checkQueryParamsIfProvided(queryParams);
OwnPtr<CacheMatchCallbacks> ownedCallbacks(adoptPtr(callbacks));
- return callbacks->onError(new WebServiceWorkerCacheError(m_error));
+ return callbacks->onError(m_error);
}
void dispatchMatchAll(CacheWithResponsesCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
@@ -122,7 +122,7 @@ public:
checkQueryParamsIfProvided(queryParams);
OwnPtr<CacheWithResponsesCallbacks> ownedCallbacks(adoptPtr(callbacks));
- return callbacks->onError(new WebServiceWorkerCacheError(m_error));
+ return callbacks->onError(m_error);
}
void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest* webRequest, const QueryParams& queryParams) override
@@ -134,7 +134,7 @@ public:
}
OwnPtr<CacheWithRequestsCallbacks> ownedCallbacks(adoptPtr(callbacks));
- return callbacks->onError(new WebServiceWorkerCacheError(m_error));
+ return callbacks->onError(m_error);
}
void dispatchBatch(CacheBatchCallbacks* callbacks, const WebVector<BatchOperation>& batchOperations) override
@@ -474,7 +474,7 @@ public:
void dispatchMatch(CacheMatchCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
{
OwnPtr<CacheMatchCallbacks> ownedCallbacks(adoptPtr(callbacks));
- return callbacks->onSuccess(&m_response);
+ return callbacks->onSuccess(m_response);
}
private:
@@ -510,7 +510,7 @@ public:
void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest* webRequest, const QueryParams& queryParams) override
{
OwnPtr<CacheWithRequestsCallbacks> ownedCallbacks(adoptPtr(callbacks));
- return callbacks->onSuccess(&m_requests);
+ return callbacks->onSuccess(m_requests);
}
private:
@@ -555,7 +555,7 @@ public:
void dispatchMatchAll(CacheWithResponsesCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
{
OwnPtr<CacheWithResponsesCallbacks> ownedCallbacks(adoptPtr(callbacks));
- return callbacks->onSuccess(&m_responses);
+ return callbacks->onSuccess(m_responses);
}
void dispatchBatch(CacheBatchCallbacks* callbacks, const WebVector<BatchOperation>& batchOperations) override

Powered by Google App Engine
This is Rietveld 408576698