components/about_handler/BUILD.gn - Issue 1284173003: Create a about handler component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/about_handler/BUILD.gn

Issue 1284173003: Create a about handler component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	droger 2015/08/12 14:41:01 Nit: 2015 Nit: 2015 Jitu( very slow this week) 2015/08/13 05:34:52 Done. Show quoted text On 2015/08/12 14:41:01, droger wrote: > Nit: 2015 Done.
2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("common") {	5 static_library("about_handler") {

6 sources = [	6 sources = [

7 "error_page_params.cc",	7 "about_protocol_handler.cc",

8 "error_page_params.h",	8 "about_protocol_handler.h",

9 "net_error_info.cc",	9 "url_request_about_job.cc",

10 "net_error_info.h",	10 "url_request_about_job.h",

11 ]	11 ]

12	12

13 deps = [	13 deps = [

14 "//base",	14 "//base",

15 "//url",	15 "//net",

16 ]	16 ]

17 }	17 }

OLD	NEW