components/about_handler.gypi - Issue 1284173003: Create a about handler component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/about_handler.gypi

Issue 1284173003: Create a about handler component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
	droger 2015/08/12 14:41:01 Nit: remove (c) Nit: remove (c) Jitu( very slow this week) 2015/08/13 05:34:52 Done. Show quoted text On 2015/08/12 14:41:01, droger wrote: > Nit: remove (c) Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'about_handler',

	9 'type': '<(component)',

	10 'dependencies': [

	11 '../base/base.gyp:base',

	12 '../net/net.gyp:net',

	13 ],

	14 'include_dirs': [

	15 '..',

	16 ],

	17 'sources': [

	18 'about_handler/about_protocol_handler.cc',

	19 'about_handler/about_protocol_handler.h',

	20 'about_handler/url_request_about_job.cc',

	21 'about_handler/url_request_about_job.h',

	22 ],

	23 },

	24 ],

	25 }

OLD	NEW