Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284173002: Revert[2] "move some public headers into private" (Closed)

Created:
5 years, 4 months ago by reed2
Modified:
5 years, 4 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] "move some public headers into private" This reverts commit 4cf9e7e14797f87f08b2078fa1afaf731cbf8f52. BUG=skia: TBR= NOTRY=True Committed: https://skia.googlesource.com/skia/+/9d20ee57d72a3850a6b51f2f2b00e00978be3864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -659 lines) Patch
M gyp/animator.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/core.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M gyp/sfnt.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D include/core/SkEndian.h View 1 chunk +0 lines, -194 lines 0 comments Download
D include/core/SkFloatBits.h View 1 chunk +0 lines, -132 lines 0 comments Download
D include/core/SkFloatingPoint.h View 1 chunk +0 lines, -170 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypeface.h View 1 chunk +1 line, -1 line 0 comments Download
D include/core/SkWeakRefCnt.h View 1 chunk +0 lines, -159 lines 0 comments Download
A + include/private/SkFloatBits.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkFloatingPoint.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkWeakRefCnt.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/svg/parser/SkSVGParser.h View 1 chunk +0 lines, -1 line 0 comments Download
A + src/core/SkEndian.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284173002/1
5 years, 4 months ago (2015-08-12 11:30:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284173002/1
5 years, 4 months ago (2015-08-12 11:41:32 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 11:42:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9d20ee57d72a3850a6b51f2f2b00e00978be3864

Powered by Google App Engine
This is Rietveld 408576698