Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 128413004: submit_try: create the diff file using git, rather than relying on trychange.py (Closed)

Created:
6 years, 11 months ago by borenet
Modified:
6 years, 11 months ago
Reviewers:
epoger, rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

submit_try: create the diff file using git, rather than relying on trychange.py BUG=skia:1862 (SkipBuildbotRuns) R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=12967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M tools/submit_try View 2 chunks +30 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
borenet
6 years, 11 months ago (2014-01-08 16:41:52 UTC) #1
epoger
lgtm
6 years, 11 months ago (2014-01-08 16:47:00 UTC) #2
borenet
6 years, 11 months ago (2014-01-08 21:00:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698