Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1284103006: [test] Remove FLAG_always_opt special case in NotifyDeoptimized (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove FLAG_always_opt special case in NotifyDeoptimized Always unlink optimized code on deopt, even when FLAG_always_opt is present, because assumptions that the code made could have become invalid. BUG=v8:4375 LOG=n R=mstarzinger@chromium.org Committed: https://crrev.com/bb9f374fc2c40da98409d06ca057775977bf79e3 Cr-Commit-Position: refs/heads/master@{#30196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jakob Kummerow
PTAL.
5 years, 4 months ago (2015-08-17 12:50:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284103006/1
5 years, 4 months ago (2015-08-17 12:51:05 UTC) #3
Michael Starzinger
LGTM. Let's keep an eye out for some exotic bots starting to timeout.
5 years, 4 months ago (2015-08-17 12:53:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-17 13:14:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284103006/1
5 years, 4 months ago (2015-08-17 13:24:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 13:26:31 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 13:26:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb9f374fc2c40da98409d06ca057775977bf79e3
Cr-Commit-Position: refs/heads/master@{#30196}

Powered by Google App Engine
This is Rietveld 408576698