Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1284093002: GN: Don't explicitly define __ANDROID__ now that clang defines it automatically (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clang1
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index d4a10c8899988225d8854c0c0d38affd6e74157c..80b13e6701dea860bb18cb0ee9a3dd1a907b7692 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -559,10 +559,6 @@ config("compiler") {
}
defines += [ "ANDROID" ]
- if (is_clang) {
- # GCC provides this as a built-in macro, but clang does not.
- defines += [ "__ANDROID__" ]
- }
# The NDK has these things, but doesn't define the constants
# to say that it does. Define them here instead.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698