Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: build/android/emma_coverage_stats.py

Issue 1284083004: Fractional line coverage + logging change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/emma_coverage_stats_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/emma_coverage_stats.py
diff --git a/build/android/emma_coverage_stats.py b/build/android/emma_coverage_stats.py
index d882cea6e68cdc07da02e0dbf6be2b8437a78b26..b6620febd40086eec5dac2d87deaefe06ee9bb75 100755
--- a/build/android/emma_coverage_stats.py
+++ b/build/android/emma_coverage_stats.py
@@ -300,6 +300,7 @@ class _EmmaCoverageStats(object):
'line': line.source,
'coverage': line.covered_status,
'changed': line.lineno in line_numbers,
+ 'fractional_coverage': line.fractional_line_coverage,
}
for line in total_line_coverage
]
@@ -395,8 +396,7 @@ class _EmmaCoverageStats(object):
if os.path.splitext(file_path)[1] == '.java' and os.path.exists(file_path):
return True
else:
- logging.debug(
- 'Skipping file %s, cannot compute code coverage.', file_path)
+ logging.info('Skipping file %s, cannot compute code coverage.', file_path)
return False
@staticmethod
@@ -445,8 +445,7 @@ def GenerateCoverageReport(line_coverage_file, out_file_path, coverage_dir):
coverage_results = {}
if files_for_coverage:
code_coverage = _EmmaCoverageStats(coverage_dir, files_for_coverage.keys())
- coverage_results = code_coverage.GetCoverageDict(
- files_for_coverage)
+ coverage_results = code_coverage.GetCoverageDict(files_for_coverage)
else:
logging.info('No Java files requiring coverage were included in %s.',
line_coverage_file)
« no previous file with comments | « no previous file | build/android/emma_coverage_stats_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698