runtime/observatory/lib/src/service/object.dart - Issue 1284063003: Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1284063003: Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/instance_view.html ('k') | runtime/observatory/tests/service/get_version_rpc_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/service/object.dart

diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart

index 3c8e6394b081c47e63d1f38c7d9aec5087b30d1d..dd3a70237f09556a1eaa8dbc21a33096f68d82a7 100644

--- a/runtime/observatory/lib/src/service/object.dart

+++ b/runtime/observatory/lib/src/service/object.dart

@@ -2155,6 +2155,8 @@ class Instance extends ServiceObject {

@observable Function twoByteFunction; // If a RegExp.

@observable Function externalOneByteFunction; // If a RegExp.

@observable Function externalTwoByteFunction; // If a RegExp.

+ @observable bool isCaseSensitive; // If a RegExp.

+ @observable bool isMultiLine; // If a RegExp.

bool get isAbstractType {

return (kind == 'Type' || kind == 'TypeRef' ||

@@ -2219,6 +2221,8 @@ class Instance extends ServiceObject {

twoByteFunction = map['_twoByteFunction'];

externalOneByteFunction = map['_externalOneByteFunction'];

externalTwoByteFunction = map['_externalTwoByteFunction'];

+ isCaseSensitive = map['_isCaseSensitive'];

Cutch 2015/08/13 22:32:36 these are public keys now right?

rmacnak 2015/08/13 22:45:21 Yes, fixed

+ isMultiLine = map['_isMultiLine'];

nativeFields = map['_nativeFields'];

fields = map['fields'];