Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1284043004: Add internal links section to skia.org (Closed)

Created:
5 years, 4 months ago by hcm
Modified:
5 years, 4 months ago
Reviewers:
jcgregorio, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix spacing #

Patch Set 3 : minor capitalization tweak #

Total comments: 2

Patch Set 4 : add bullets, remove line breaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A site/dev/internal/index.md View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hcm
On 2015/08/17 19:45:35, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:jcgregorio@google.com, mailto:reed@google.com Interim step ...
5 years, 4 months ago (2015-08-17 19:47:26 UTC) #2
jcgregorio
https://codereview.chromium.org/1284043004/diff/40001/site/dev/internal/index.md File site/dev/internal/index.md (right): https://codereview.chromium.org/1284043004/diff/40001/site/dev/internal/index.md#newcode7 site/dev/internal/index.md:7: <br> Why the br's? https://codereview.chromium.org/1284043004/diff/40001/site/dev/internal/index.md#newcode10 site/dev/internal/index.md:10: [Granting access to ...
5 years, 4 months ago (2015-08-18 12:03:40 UTC) #3
hcm
On 2015/08/18 12:03:40, jcgregorio wrote: > https://codereview.chromium.org/1284043004/diff/40001/site/dev/internal/index.md > File site/dev/internal/index.md (right): > > https://codereview.chromium.org/1284043004/diff/40001/site/dev/internal/index.md#newcode7 > ...
5 years, 4 months ago (2015-08-18 17:02:27 UTC) #4
jcgregorio
lgtm
5 years, 4 months ago (2015-08-18 17:14:11 UTC) #5
jcgregorio
On 2015/08/18 at 17:02:27, hcm wrote: > On 2015/08/18 12:03:40, jcgregorio wrote: > > https://codereview.chromium.org/1284043004/diff/40001/site/dev/internal/index.md ...
5 years, 4 months ago (2015-08-18 17:14:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284043004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284043004/60001
5 years, 4 months ago (2015-08-18 17:37:23 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:38:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7b076c41a1da26626efbb21cf1d8b344e11d9f84

Powered by Google App Engine
This is Rietveld 408576698