Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 128403007: Adding fetch recipes for nacl, naclports, and depot_tools. (Closed)

Created:
6 years, 11 months ago by bradn
Modified:
6 years, 11 months ago
Reviewers:
Dirk Pranke, agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Adding fetch recipes for nacl, naclports, and depot_tools. BUG=None TEST=local R=agable@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=243697

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
A + recipes/depot_tools.py View 4 chunks +6 lines, -8 lines 0 comments Download
A + recipes/nacl.py View 3 chunks +10 lines, -11 lines 0 comments Download
A + recipes/naclports.py View 1 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
Largely culting of cargo so please check my assumptions. Also, these seem to create clients ...
6 years, 11 months ago (2014-01-08 20:09:28 UTC) #1
Dirk Pranke
I'm not agable, but this looks lgtm. I was initially thrown by the idea of ...
6 years, 11 months ago (2014-01-08 23:05:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/128403007/1
6 years, 11 months ago (2014-01-08 23:38:54 UTC) #3
commit-bot: I haz the power
Commit queue failed due to new patchset.
6 years, 11 months ago (2014-01-08 23:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/128403007/50001
6 years, 11 months ago (2014-01-08 23:42:34 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 23:44:20 UTC) #6
Message was sent while issue was closed.
Change committed as 243697

Powered by Google App Engine
This is Rietveld 408576698