Fix delivery of percent full notifications from TracingController. This was broken by revision 2428…

Fix delivery of percent full notifications from TracingController. This was broken by revision 242806.

BUG=332056
TEST=Record with about:tracing

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243984

[Marshall, 2014-01-08 20:03:06]

Xianzhu=Please review
dsinclair=Owner FYI

Only callbacks originating from TraceMessageFilter and representing an actual
sub-process response should pass a non-NULL |trace_message_filter| argument to
OnTraceBufferPercentFullReply. In this case we were passing a non-NULL
|trace_message_filter| for the |pending_trace_buffer_percent_full_ack_count_ ==
1| case which caused the |trace_message_filter &&
    !pending_trace_buffer_percent_full_filters_.erase(trace_message_filter)|
check to fail and the callback to never be executed.

[Xianzhu, 2014-01-08 20:58:16]

https://codereview.chromium.org/128403006/diff/1/content/browser/tracing/trac...
File content/browser/tracing/tracing_controller_impl.cc (right):

https://codereview.chromium.org/128403006/diff/1/content/browser/tracing/trac...
content/browser/tracing/tracing_controller_impl.cc:768:
TraceLog::GetInstance()->GetBufferPercentFull()));
It seems that we could call TraceLog::GetInstance->GetBufferPercentFull() in
TracingControllerImpl::GetTraceBufferPercentFull() unconditionally, to avoid the
above code.

[Marshall, 2014-01-09 17:09:09]

https://codereview.chromium.org/128403006/diff/1/content/browser/tracing/trac...
File content/browser/tracing/tracing_controller_impl.cc (right):

https://codereview.chromium.org/128403006/diff/1/content/browser/tracing/trac...
content/browser/tracing/tracing_controller_impl.cc:768:
TraceLog::GetInstance()->GetBufferPercentFull()));
On 2014/01/08 20:58:16, Xianzhu wrote:
> It seems that we could call TraceLog::GetInstance->GetBufferPercentFull() in
> TracingControllerImpl::GetTraceBufferPercentFull() unconditionally, to avoid
the
> above code.

Done.

[Xianzhu, 2014-01-09 17:11:31]

lgtm. Thanks!

[dsinclair, 2014-01-09 18:13:31]

lgtm

[commit-bot: I haz the power, 2014-01-09 18:20:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marshall@chromium.org/128403006/40001

[commit-bot: I haz the power, 2014-01-09 21:46:08]

Change committed as 243984