Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 1284013003: [turbofan] LoadGlobalParameters::slot_index() should just return an int. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] LoadGlobalParameters::slot_index() should just return an int. Clang says: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] Committed: https://crrev.com/52a2563e68e3b1db739d43c50c555d19efa0e1b2 Cr-Commit-Position: refs/heads/master@{#30123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-operator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Lei Zhang
This was introduced in the past month. I see it a lot when I build ...
5 years, 4 months ago (2015-08-12 02:05:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284013003/1
5 years, 4 months ago (2015-08-12 02:40:15 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 4 months ago (2015-08-12 02:40:16 UTC) #6
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-08-12 04:07:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284013003/1
5 years, 4 months ago (2015-08-12 04:07:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 04:40:27 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 04:40:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52a2563e68e3b1db739d43c50c555d19efa0e1b2
Cr-Commit-Position: refs/heads/master@{#30123}

Powered by Google App Engine
This is Rietveld 408576698