Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3187)

Unified Diff: chrome/browser/search/local_omnibox_popup_source.cc

Issue 12840003: Implement local NTP for fallback. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Respond. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/local_omnibox_popup_source.cc
diff --git a/chrome/browser/search/local_omnibox_popup_source.cc b/chrome/browser/search/local_omnibox_popup_source.cc
index 4edee686d8ef7794e0273e785124454fab57753a..a4bd0932158af97635dcc1f6f216dcdc56de7d40 100644
--- a/chrome/browser/search/local_omnibox_popup_source.cc
+++ b/chrome/browser/search/local_omnibox_popup_source.cc
@@ -16,7 +16,7 @@
namespace {
const char kHTMLFilename[] = "local-omnibox-popup.html";
-const char kJsFilename[] = "local-omnibox-popup.js";
+const char kJSFilename[] = "local-omnibox-popup.js";
Dan Beam 2013/03/25 18:13:49 I'd rather you just change everything else to kHtm
jeremycho 2013/03/25 21:27:16 Done.
const char kCSSFilename[] = "local-omnibox-popup.css";
const char kPageIconFilename[] = "images/page_icon.png";
const char kPageIcon2xFilename[] = "images/2x/page_icon.png";
@@ -42,7 +42,7 @@ void LocalOmniboxPopupSource::StartDataRequest(
int identifier = -1;
if (path == kHTMLFilename) {
identifier = IDR_LOCAL_OMNIBOX_POPUP_HTML;
- } else if (path == kJsFilename) {
+ } else if (path == kJSFilename) {
identifier = IDR_LOCAL_OMNIBOX_POPUP_JS;
} else if (path == kCSSFilename) {
identifier = IDR_LOCAL_OMNIBOX_POPUP_CSS;
@@ -68,7 +68,7 @@ std::string LocalOmniboxPopupSource::GetMimeType(
const std::string& path) const {
if (path == kHTMLFilename)
return "text/html";
- if (path == kJsFilename)
+ if (path == kJSFilename)
return "application/javascript";
if (path == kCSSFilename)
return "text/css";
@@ -85,7 +85,7 @@ bool LocalOmniboxPopupSource::ShouldServiceRequest(
if (request->url().SchemeIs(chrome::kChromeSearchScheme)) {
DCHECK(StartsWithASCII(request->url().path(), "/", true));
std::string filename = request->url().path().substr(1);
- return filename == kHTMLFilename || filename == kJsFilename ||
+ return filename == kHTMLFilename || filename == kJSFilename ||
filename == kCSSFilename || filename == kPageIconFilename ||
filename == kPageIcon2xFilename || filename == kSearchIconFilename ||
filename == kSearchIcon2xFilename;

Powered by Google App Engine
This is Rietveld 408576698