Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: chrome/browser/search/local_ntp_source.h

Issue 12840003: Implement local NTP for fallback. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Respond. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/local_ntp_source.h
diff --git a/chrome/browser/search/local_omnibox_popup_source.h b/chrome/browser/search/local_ntp_source.h
similarity index 56%
copy from chrome/browser/search/local_omnibox_popup_source.h
copy to chrome/browser/search/local_ntp_source.h
index a85d2e49d3c721956dfd0afd9fd5046e334659de..1e26246d5c1b9cd2ad50702b042cf091568ee550 100644
--- a/chrome/browser/search/local_omnibox_popup_source.h
+++ b/chrome/browser/search/local_ntp_source.h
@@ -2,20 +2,23 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_SEARCH_LOCAL_OMNIBOX_POPUP_SOURCE_H_
-#define CHROME_BROWSER_SEARCH_LOCAL_OMNIBOX_POPUP_SOURCE_H_
+#ifndef CHROME_BROWSER_SEARCH_LOCAL_NTP_SOURCE_H_
+#define CHROME_BROWSER_SEARCH_LOCAL_NTP_SOURCE_H_
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "content/public/browser/url_data_source.h"
-// Serves HTML and resources for the local omnibox popup i.e.
-// chrome-search://local-omnibox-popup/local_omnibox_popup.html
-class LocalOmniboxPopupSource : public content::URLDataSource {
+// Serves HTML and resources for the local new tab page i.e.
+// chrome-search://local-ntp/local-ntp.html
+class LocalNTPSource : public content::URLDataSource {
public:
- LocalOmniboxPopupSource();
+ LocalNTPSource();
- // content::URLDataSource overrides.
+ private:
+ virtual ~LocalNTPSource();
+
+ // Overridden from content::URLDataSource:
Dan Beam 2013/03/25 18:13:49 ^ why are you putting these in private:?
jeremycho 2013/03/25 21:27:16 There didn't seem to be a reason to expose them.
Dan Beam 2013/03/25 21:37:39 static_cast<parent*>(class)->DoParentThing() still
virtual std::string GetSource() OVERRIDE;
virtual void StartDataRequest(
const std::string& path,
@@ -25,10 +28,7 @@ class LocalOmniboxPopupSource : public content::URLDataSource {
virtual bool ShouldServiceRequest(
const net::URLRequest* request) const OVERRIDE;
- private:
- virtual ~LocalOmniboxPopupSource();
-
- DISALLOW_COPY_AND_ASSIGN(LocalOmniboxPopupSource);
+ DISALLOW_COPY_AND_ASSIGN(LocalNTPSource);
};
-#endif // CHROME_BROWSER_SEARCH_LOCAL_OMNIBOX_POPUP_SOURCE_H_
+#endif // CHROME_BROWSER_SEARCH_LOCAL_NTP_SOURCE_H_

Powered by Google App Engine
This is Rietveld 408576698