Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5998)

Unified Diff: chrome/browser/search/local_omnibox_popup_source.h

Issue 12840003: Implement local NTP for fallback. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Respond to Samarth's comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/local_omnibox_popup_source.h
diff --git a/chrome/browser/search/local_omnibox_popup_source.h b/chrome/browser/search/local_omnibox_popup_source.h
index a85d2e49d3c721956dfd0afd9fd5046e334659de..de51389a2f8f948669cac60a7f05d71f9bf52fe6 100644
--- a/chrome/browser/search/local_omnibox_popup_source.h
+++ b/chrome/browser/search/local_omnibox_popup_source.h
@@ -15,7 +15,10 @@ class LocalOmniboxPopupSource : public content::URLDataSource {
public:
LocalOmniboxPopupSource();
- // content::URLDataSource overrides.
+ private:
+ virtual ~LocalOmniboxPopupSource();
+
+ // Overriden from content::URLDataSource:
samarth 2013/03/19 02:35:53 nit: Overridden
jeremycho 2013/03/19 03:30:35 Done.
virtual std::string GetSource() OVERRIDE;
virtual void StartDataRequest(
const std::string& path,
@@ -25,9 +28,6 @@ class LocalOmniboxPopupSource : public content::URLDataSource {
virtual bool ShouldServiceRequest(
const net::URLRequest* request) const OVERRIDE;
- private:
- virtual ~LocalOmniboxPopupSource();
-
DISALLOW_COPY_AND_ASSIGN(LocalOmniboxPopupSource);
};

Powered by Google App Engine
This is Rietveld 408576698