Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6109)

Unified Diff: chrome/browser/instant/search_unittest.cc

Issue 12840003: Implement local NTP for fallback. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Respond to Samarth's comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/search_unittest.cc
diff --git a/chrome/browser/instant/search_unittest.cc b/chrome/browser/instant/search_unittest.cc
index 6a210d15c802abe1e3b05fabfaf019ad698f1a1b..a619ceb416192ae9a70fea78b71ccd717f88faf5 100644
--- a/chrome/browser/instant/search_unittest.cc
+++ b/chrome/browser/instant/search_unittest.cc
@@ -139,6 +139,7 @@ TEST_F(SearchTest, ShouldAssignURLToInstantRendererExtendedEnabled) {
const SearchTestCase kTestCases[] = {
{chrome::kChromeSearchLocalOmniboxPopupURL, true, ""},
+ {chrome::kChromeSearchLocalNTPURL, true, ""},
{"https://foo.com/instant?strk", true, ""},
{"https://foo.com/instant#strk", true, ""},
{"https://foo.com/instant?strk=0", true, ""},
@@ -186,6 +187,7 @@ const SearchTestCase kInstantNTPTestCases[] = {
{"chrome://blank/", false, "Chrome scheme"},
{"chrome-search//foo", false, "Chrome-search scheme"},
{chrome::kChromeSearchLocalOmniboxPopupURL, false, "Local omnibox popup"},
+ {chrome::kChromeSearchLocalNTPURL, true, "Local new tab page"},
samarth 2013/03/18 22:09:19 super nit: keep the columns aligned
jeremycho 2013/03/18 23:18:52 Done.
{"https://bar.com/instant?strk=1", false, "Random non-search page"},
};

Powered by Google App Engine
This is Rietveld 408576698