Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Unified Diff: chrome/browser/instant/local_ntp_source.h

Issue 12840003: Implement local NTP for fallback. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Respond to Samarth's comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/local_ntp_source.h
diff --git a/chrome/browser/instant/local_omnibox_popup_source.h b/chrome/browser/instant/local_ntp_source.h
similarity index 64%
copy from chrome/browser/instant/local_omnibox_popup_source.h
copy to chrome/browser/instant/local_ntp_source.h
index fb40fcd2a43a1094977d1be85f62ee0624fdc211..0a75fc4260dadc29dda0d9284b433881656fd478 100644
--- a/chrome/browser/instant/local_omnibox_popup_source.h
+++ b/chrome/browser/instant/local_ntp_source.h
@@ -2,18 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_INSTANT_LOCAL_OMNIBOX_POPUP_SOURCE_H_
-#define CHROME_BROWSER_INSTANT_LOCAL_OMNIBOX_POPUP_SOURCE_H_
+#ifndef CHROME_BROWSER_INSTANT_LOCAL_NTP_SOURCE_H_
+#define CHROME_BROWSER_INSTANT_LOCAL_NTP_SOURCE_H_
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "content/public/browser/url_data_source.h"
// Serves HTML and resources for the local omnibox popup i.e.
samarth 2013/03/18 22:09:19 Please update comment.
jeremycho 2013/03/18 23:18:52 Done.
-// chrome-search://local-omnibox-popup/local_omnibox_popup.html
-class LocalOmniboxPopupSource : public content::URLDataSource {
+// chrome-search://local-ntp/local-ntp.html
+class LocalNTPSource : public content::URLDataSource {
public:
- LocalOmniboxPopupSource();
+ LocalNTPSource();
// content::URLDataSource overrides.
samarth 2013/03/18 22:09:19 nit: the Chromium style is "Overriden from content
samarth 2013/03/18 22:09:19 Also, can you make these private?
jeremycho 2013/03/18 23:18:52 Done.
jeremycho 2013/03/18 23:18:52 Done. Also updated local_omnibox_popup.
virtual std::string GetSource() OVERRIDE;
@@ -26,9 +26,9 @@ class LocalOmniboxPopupSource : public content::URLDataSource {
const net::URLRequest* request) const OVERRIDE;
private:
- virtual ~LocalOmniboxPopupSource();
+ virtual ~LocalNTPSource();
- DISALLOW_COPY_AND_ASSIGN(LocalOmniboxPopupSource);
+ DISALLOW_COPY_AND_ASSIGN(LocalNTPSource);
};
-#endif // CHROME_BROWSER_INSTANT_LOCAL_OMNIBOX_POPUP_SOURCE_H_
+#endif // CHROME_BROWSER_INSTANT_LOCAL_NTP_SOURCE_H_

Powered by Google App Engine
This is Rietveld 408576698