Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1283983002: Enable native targets used for non-SFI (Closed)

Created:
5 years, 4 months ago by Petr Hosek
Modified:
5 years, 4 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-compiler-rt.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable native targets used for non-SFI We currently don't allow native target for clang_nacl, but we need to lift this restriction to enable the use of nacl-clang to build support libraries for non-SFI mode. BUG= None R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-compiler-rt.git;a=commit;h=2e5064890a3175dba2de190a8918b83509c0cd4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M make/platform/clang_nacl.mk View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Petr Hosek
PTAL
5 years, 4 months ago (2015-08-11 22:15:53 UTC) #2
Derek Schuff
lgtm
5 years, 4 months ago (2015-08-12 00:03:46 UTC) #3
Petr Hosek
5 years, 4 months ago (2015-08-12 00:04:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e5064890a3175dba2de190a8918b83509c0cd4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698