Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: runtime/vm/atomic_test.cc

Issue 1283963003: Fix build by casting constants and using more compatible intrinsic name. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix remaining test. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/atomic_macos.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/atomic_test.cc
diff --git a/runtime/vm/atomic_test.cc b/runtime/vm/atomic_test.cc
index e0fdbe920bf788a9265a25efd69975743d0664d7..35f8b51dcdfae9044ef9e0b688c7c87585254ab4 100644
--- a/runtime/vm/atomic_test.cc
+++ b/runtime/vm/atomic_test.cc
@@ -12,8 +12,9 @@ namespace dart {
UNIT_TEST_CASE(FetchAndIncrement) {
uintptr_t v = 42;
- EXPECT_EQ(42, AtomicOperations::FetchAndIncrement(&v));
- EXPECT_EQ(43, v);
+ EXPECT_EQ(static_cast<uintptr_t>(42),
+ AtomicOperations::FetchAndIncrement(&v));
+ EXPECT_EQ(static_cast<uintptr_t>(43), v);
}
@@ -30,7 +31,7 @@ UNIT_TEST_CASE(FetchAndAdd) {
UNIT_TEST_CASE(LoadRelaxed) {
uword v = 42;
- EXPECT_EQ(42, AtomicOperations::LoadRelaxed(&v));
+ EXPECT_EQ(static_cast<uword>(42), AtomicOperations::LoadRelaxed(&v));
}
} // namespace dart
« no previous file with comments | « runtime/vm/atomic_macos.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698