Stage --harmony-array-includes

Stage --harmony-array-includes

BUG=v8:3575
R=adamk@chromium.org, rossberg@chromium.org
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/43655380bde57da6c566050d7f65cc8fec719963
Cr-Commit-Position: refs/heads/master@{#30121}

[domenic, 2015-08-11 18:08:04]

Intent to ship: https://groups.google.com/forum/#!topic/v8-users/-a8_8cb6FRI

[adamk, 2015-08-11 18:49:05]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 18:49:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283963002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283963002/1

[adamk, 2015-08-11 18:51:40]

Didn't realize this wasn't staged yet. Can you make this a staging CL instead to
give us at least a little coverage at that level before moving to shipped?

[domenic, 2015-08-11 18:54:54]

On 2015/08/11 at 18:51:40, adamk wrote:
> Didn't realize this wasn't staged yet. Can you make this a staging CL instead
to give us at least a little coverage at that level before moving to shipped?

Done.

[adamk, 2015-08-11 20:45:19]

Looks like webkit/fast/js/Object-getOwnPropertyNames is failing (you can
reproduce locally by explicitly running the "webkit" tests:

tools/run-tests.py webkit

[caitp (gmail), 2015-08-11 20:51:13]

On 2015/08/11 20:45:19, adamk wrote:
> Looks like webkit/fast/js/Object-getOwnPropertyNames is failing (you can
> reproduce locally by explicitly running the "webkit" tests:
> 
> tools/run-tests.py webkit

https://github.com/v8/v8-git-mirror/blob/325fbd0e243f6d43c977452651cf4be9a0da...

These break pretty much every time a flag gets flipped, it seems like. Probably
will want to run tests on chromium/blink bots too, they may need updates as well

[adamk, 2015-08-11 21:03:57]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 21:04:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283963002/20001

[domenic, 2015-08-11 21:19:55]

On 2015/08/11 at 20:51:13, caitpotter88 wrote:
> On 2015/08/11 20:45:19, adamk wrote:
> > Looks like webkit/fast/js/Object-getOwnPropertyNames is failing (you can
> > reproduce locally by explicitly running the "webkit" tests:
> > 
> > tools/run-tests.py webkit
> 
>
https://github.com/v8/v8-git-mirror/blob/325fbd0e243f6d43c977452651cf4be9a0da...
> 
> These break pretty much every time a flag gets flipped, it seems like.
Probably will want to run tests on chromium/blink bots too, they may need
updates as well

Now that we're only staging instead of shipping, this seems to no longer matter.
(Right?) But I'll keep these in mind for the shipping CL.

[adamk, 2015-08-11 21:22:13]

On 2015/08/11 21:19:55, domenic wrote:
> On 2015/08/11 at 20:51:13, caitpotter88 wrote:
> > On 2015/08/11 20:45:19, adamk wrote:
> > > Looks like webkit/fast/js/Object-getOwnPropertyNames is failing (you can
> > > reproduce locally by explicitly running the "webkit" tests:
> > > 
> > > tools/run-tests.py webkit
> > 
> >
>
https://github.com/v8/v8-git-mirror/blob/325fbd0e243f6d43c977452651cf4be9a0da...
> > 
> > These break pretty much every time a flag gets flipped, it seems like.
> Probably will want to run tests on chromium/blink bots too, they may need
> updates as well
> 
> Now that we're only staging instead of shipping, this seems to no longer
matter.
> (Right?) But I'll keep these in mind for the shipping CL.

lgtm if this passes tests, I thought we might run more tests with --harmony on
but that seems to be only test262 (are there no test262 tests for A.p.includes?)

[domenic, 2015-08-11 21:25:19]

On 2015/08/11 at 21:22:13, adamk wrote:

> lgtm if this passes tests, I thought we might run more tests with --harmony on
but that seems to be only test262 (are there no test262 tests for A.p.includes?)

Not yet; I'll poke Brian about what his policies are for test262 and stages and
such. There's a stale PR that he didn't accept back in the stage 1 days.

[adamk, 2015-08-11 21:26:30]

On 2015/08/11 21:25:19, domenic wrote:
> On 2015/08/11 at 21:22:13, adamk wrote:
> 
> > lgtm if this passes tests, I thought we might run more tests with --harmony
on
> but that seems to be only test262 (are there no test262 tests for
A.p.includes?)
> 
> Not yet; I'll poke Brian about what his policies are for test262 and stages
and
> such. There's a stale PR that he didn't accept back in the stage 1 days.

Ah, weird, I see that the acceptance tests aren't needed until stage 4. Huh.

[commit-bot: I haz the power, 2015-08-11 21:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 21:54:55]

Dry run: This issue passed the CQ dry run.

[domenic, 2015-08-11 21:59:13]

The CQ bit was checked by domenic@chromium.org

[commit-bot: I haz the power, 2015-08-11 21:59:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283963002/20001

[commit-bot: I haz the power, 2015-08-11 22:00:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-11 22:01:34]

Patchset 2 (id:??) landed as
https://crrev.com/43655380bde57da6c566050d7f65cc8fec719963
Cr-Commit-Position: refs/heads/master@{#30121}