Issue 1283853002: Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283853002: Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty (Closed)

Created:
5 years, 4 months ago by egdaniel

Modified:
5 years, 4 months ago

Reviewers:
bungeman-skia, f(malita), reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty (patchset #1 id:1 of https://codereview.chromium.org/1284693002/ ) Reason for revert: Breaking DEPS roll on Assert in SkTextBlobBuilder::TightRunBounds. Original issue's description: > [TextBlob] Fall back to TightRunBounds when the font bounds are empty > > Empty font bounds are likely an indication of a font bug. As a best > effort, we can use TightRunBounds in this easily detectable case. > > BUG=507022 > R=reed@google.com,bungeman@google.com > > Committed: https://skia.googlesource.com/skia/+/d6b99cc6b84b3ec864221cbe9945d203bd9eb072 TBR=bungeman@google.com,reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507022 Committed: https://skia.googlesource.com/skia/+/2a5ca89ea1a5093b5d143740619ca162a74fe0e7

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	src/core/SkTextBlob.cpp	View		2 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

egdaniel

Created Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty

5 years, 4 months ago (2015-08-10 18:02:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283853002/1

5 years, 4 months ago (2015-08-10 18:02:40 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-10 18:02:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a5ca89ea1a5093b5d143740619ca162a74fe0e7

Expand Messages | Collapse Messages