Issue 1283833002: [heap] Avoid inclusion of heap internals in v8.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283833002: [heap] Avoid inclusion of heap internals in v8.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger

Modified:
5 years, 4 months ago

Reviewers:
Michael Lippautz

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[heap] Avoid inclusion of heap internals in v8.h header. R=mlippautz@chromium.org Committed: https://crrev.com/986f1c10a1824030c7464baae6493696e11b4ace Cr-Commit-Position: refs/heads/master@{#30093}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -8 lines)			Patch
M	src/DEPS	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/heap/heap-inl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/v8.h	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283833002/1

5 years, 4 months ago (2015-08-10 17:04:27 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-10 17:06:23 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/986f1c10a1824030c7464baae6493696e11b4ace
Cr-Commit-Position: refs/heads/master@{#30093}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages