Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: sdk/lib/core/set.dart

Issue 12838002: Deprecate Set.isSubsetOf, make Set.containsAll accept iterable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated test expectations. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/core/set.dart
diff --git a/sdk/lib/core/set.dart b/sdk/lib/core/set.dart
index bad4c79f2c7e437d09eebfafca47b04e6d0dc7f4..8856d41e36d3c568446d22d6021b3d423aea7060 100644
--- a/sdk/lib/core/set.dart
+++ b/sdk/lib/core/set.dart
@@ -36,13 +36,17 @@ abstract class Set<E> extends Collection<E> {
/**
* Returns true if [other] contains all the elements of this Set.
+ *
+ * *Deprecated*. Use `other.containsAll(thisSet)` instead if [other]
+ * is a Set, and convert `other` to a Set if it isn't.
*/
- bool isSubsetOf(Set<E> other);
+ @deprecated
+ bool isSubsetOf(Iterable<E> other);
/**
* Returns true if this Set contains all the elements of [other].
*/
- bool containsAll(Set<E> other);
+ bool containsAll(Iterable<E> other);
/**
* Returns a new set which is the intersection between this set and [other].

Powered by Google App Engine
This is Rietveld 408576698