VM: Refactor assembler test that rely on the constant pool.

runtime/vm/assembler_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/assembler.h"
 #include "vm/globals.h"
 #include "vm/os.h"
 #include "vm/simulator.h"
 #include "vm/unit_test.h"
 #include "vm/virtual_memory.h"
 
 namespace dart {
 
 ASSEMBLER_TEST_EXTERN(StoreIntoObject);
 
 ASSEMBLER_TEST_RUN(StoreIntoObject, test) {
-#if defined(USING_SIMULATOR)
-#define test_code(value, growable_array, thread)                               \
-  Simulator::Current()->Call(                                                  \
-      bit_cast<intptr_t, uword>(test->entry()),                                \
-      reinterpret_cast<intptr_t>(value),                                       \
-      reinterpret_cast<intptr_t>(growable_array),                              \
-      reinterpret_cast<intptr_t>(thread),                                      \
-      0) /* unused parameter */
-#else
-  typedef void (*StoreData)(RawObject* value,
-                            RawObject* growable_array,
-                            Thread* thread);
-  StoreData test_code = reinterpret_cast<StoreData>(test->entry());
-#endif
+#define TEST_CODE(value, growable_array, thread)                               \
+  test->Invoke<void, RawObject*, RawObject*, Thread*>(                         \
+  value, growable_array, thread)
 
   const Array& old_array = Array::Handle(Array::New(3, Heap::kOld));
   const Array& new_array = Array::Handle(Array::New(3, Heap::kNew));
   const GrowableObjectArray& grow_old_array = GrowableObjectArray::Handle(
       GrowableObjectArray::New(old_array, Heap::kOld));
   const GrowableObjectArray& grow_new_array = GrowableObjectArray::Handle(
       GrowableObjectArray::New(old_array, Heap::kNew));
   Smi& smi = Smi::Handle();
   Thread* thread = Thread::Current();
 
   EXPECT(old_array.raw() == grow_old_array.data());
   EXPECT(!thread->StoreBufferContains(grow_old_array.raw()));
   EXPECT(old_array.raw() == grow_new_array.data());
   EXPECT(!thread->StoreBufferContains(grow_new_array.raw()));
 
   // Store Smis into the old object.
   for (int i = -128; i < 128; i++) {
     smi = Smi::New(i);
-    test_code(smi.raw(), grow_old_array.raw(), thread);
+    TEST_CODE(smi.raw(), grow_old_array.raw(), thread);
     EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
     EXPECT(!thread->StoreBufferContains(grow_old_array.raw()));
   }
 
   // Store an old object into the old object.
-  test_code(old_array.raw(), grow_old_array.raw(), thread);
+  TEST_CODE(old_array.raw(), grow_old_array.raw(), thread);
   EXPECT(old_array.raw() == grow_old_array.data());
   EXPECT(!thread->StoreBufferContains(grow_old_array.raw()));
 
   // Store a new object into the old object.
-  test_code(new_array.raw(), grow_old_array.raw(), thread);
+  TEST_CODE(new_array.raw(), grow_old_array.raw(), thread);
   EXPECT(new_array.raw() == grow_old_array.data());
   EXPECT(thread->StoreBufferContains(grow_old_array.raw()));
 
   // Store a new object into the new object.
-  test_code(new_array.raw(), grow_new_array.raw(), thread);
+  TEST_CODE(new_array.raw(), grow_new_array.raw(), thread);
   EXPECT(new_array.raw() == grow_new_array.data());
   EXPECT(!thread->StoreBufferContains(grow_new_array.raw()));
 
   // Store an old object into the new object.
-  test_code(old_array.raw(), grow_new_array.raw(), thread);
+  TEST_CODE(old_array.raw(), grow_new_array.raw(), thread);
   EXPECT(old_array.raw() == grow_new_array.data());
   EXPECT(!thread->StoreBufferContains(grow_new_array.raw()));
 }
 
 }  // namespace dart