Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1283733002: Add mojo_run --embed APP_URL and update wm urls. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add mojo_run --embed APP_URL and update wm urls. This patch adds a flag that makes it easier to run apps embedded in a wm. It also updates the window manager urls, transitioning away from mojo: urls, see #356. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4f1253df60a3269dd5525a1de73bbde163301f04

Patch Set 1 #

Patch Set 2 : Improve the comments. #

Total comments: 2

Patch Set 3 : Improve the comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -19 lines) Patch
M README.md View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M mojo/devtools/common/README.md View 1 1 chunk +7 lines, -6 lines 0 comments Download
M mojo/devtools/common/mojo_run View 4 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 4 months ago (2015-08-10 11:10:54 UTC) #2
etiennej
https://codereview.chromium.org/1283733002/diff/20001/mojo/devtools/common/mojo_run File mojo/devtools/common/mojo_run (right): https://codereview.chromium.org/1283733002/diff/20001/mojo/devtools/common/mojo_run#newcode39 mojo/devtools/common/mojo_run:39: _DEFAULT_WM = 'https://core.mojoapps.io/kiosk_wm.mojo' As I understand it, this CL ...
5 years, 4 months ago (2015-08-10 11:18:51 UTC) #3
ppi
https://codereview.chromium.org/1283733002/diff/20001/mojo/devtools/common/mojo_run File mojo/devtools/common/mojo_run (right): https://codereview.chromium.org/1283733002/diff/20001/mojo/devtools/common/mojo_run#newcode39 mojo/devtools/common/mojo_run:39: _DEFAULT_WM = 'https://core.mojoapps.io/kiosk_wm.mojo' On 2015/08/10 11:18:50, etiennej wrote: > ...
5 years, 4 months ago (2015-08-10 11:30:41 UTC) #4
etiennej
lgtm
5 years, 4 months ago (2015-08-10 11:32:21 UTC) #5
ppi
5 years, 4 months ago (2015-08-10 12:32:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4f1253df60a3269dd5525a1de73bbde163301f04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698