Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1283703004: Add includes method to typed arrays (Closed)

Created:
5 years, 4 months ago by domenic
Modified:
5 years, 4 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add includes method to typed arrays R=littledan@chromium.org, adamk@chromium.org BUG=v8:3575 LOG=Y Committed: https://crrev.com/8934b9eae722c4c74f46a2891bcee597bd934c63 Cr-Commit-Position: refs/heads/master@{#30117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -9 lines) Patch
M src/harmony-array-includes.js View 3 chunks +58 lines, -9 lines 0 comments Download
A test/mjsunit/harmony/typed-array-includes.js View 1 chunk +203 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
domenic
5 years, 4 months ago (2015-08-11 16:54:41 UTC) #1
Dan Ehrenberg
lgtm
5 years, 4 months ago (2015-08-11 17:16:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283703004/1
5 years, 4 months ago (2015-08-11 17:16:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-11 17:42:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283703004/1
5 years, 4 months ago (2015-08-11 17:53:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 17:55:12 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 17:55:34 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8934b9eae722c4c74f46a2891bcee597bd934c63
Cr-Commit-Position: refs/heads/master@{#30117}

Powered by Google App Engine
This is Rietveld 408576698