Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: content/browser/background_sync/background_sync_service_impl_unittest.cc

Issue 1283703003: Change ownership of BackgroundSyncServiceImpl to BackgroundSyncContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_service_impl_unittest.cc
diff --git a/content/browser/background_sync/background_sync_service_impl_unittest.cc b/content/browser/background_sync/background_sync_service_impl_unittest.cc
index 39a81663511129f9a1d84e4119dd2d80ce61e17d..5e177503d4ee938f9d0b59355319a939fb5eb2d1 100644
--- a/content/browser/background_sync/background_sync_service_impl_unittest.cc
+++ b/content/browser/background_sync/background_sync_service_impl_unittest.cc
@@ -106,6 +106,8 @@ class BackgroundSyncServiceImplTest : public testing::Test {
// This must be explicitly destroyed here to ensure that destruction
// of both the BackgroundSyncContext and the BackgroundSyncManager occurs on
// the correct thread.
+ background_sync_context_->Shutdown();
+ base::RunLoop().RunUntilIdle();
background_sync_context_ = nullptr;
}
@@ -169,8 +171,8 @@ class BackgroundSyncServiceImplTest : public testing::Test {
mojo::InterfaceRequest<BackgroundSyncService> service_request =
mojo::GetProxy(&service_ptr_);
// Create a new BackgroundSyncServiceImpl bound to the dummy channel
- service_impl_.reset(new BackgroundSyncServiceImpl(background_sync_context_,
- service_request.Pass()));
+ service_impl_.reset(new BackgroundSyncServiceImpl(
+ background_sync_context_.get(), service_request.Pass()));
base::RunLoop().RunUntilIdle();
}

Powered by Google App Engine
This is Rietveld 408576698