Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: content/browser/background_sync/background_sync_context_impl.h

Issue 1283703003: Change ownership of BackgroundSyncServiceImpl to BackgroundSyncContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove scoped_refptr Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_context_impl.h
diff --git a/content/browser/background_sync/background_sync_context_impl.h b/content/browser/background_sync/background_sync_context_impl.h
index 861b6d2a3fdff982d94bb572d404cd6794eabfcc..52dfdc9691c6ac92be1d9b2c6c90e482a6449719 100644
--- a/content/browser/background_sync/background_sync_context_impl.h
+++ b/content/browser/background_sync/background_sync_context_impl.h
@@ -5,14 +5,18 @@
#ifndef CONTENT_BROWSER_BACKGROUND_SYNC_BACKGROUND_SYNC_CONTEXT_IMPL_H_
#define CONTENT_BROWSER_BACKGROUND_SYNC_BACKGROUND_SYNC_CONTEXT_IMPL_H_
+#include <set>
+
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "content/common/background_sync_service.mojom.h"
#include "content/common/content_export.h"
#include "content/public/browser/background_sync_context.h"
namespace content {
class BackgroundSyncManager;
+class BackgroundSyncServiceImpl;
class ServiceWorkerContextWrapper;
// Implements the BackgroundSyncContext. One instance of this exists per
@@ -26,9 +30,19 @@ class CONTENT_EXPORT BackgroundSyncContextImpl : public BackgroundSyncContext {
// Init and Shutdown are for use on the UI thread when the
// StoragePartition is being setup and torn down.
void Init(const scoped_refptr<ServiceWorkerContextWrapper>& context);
+
+ // Shutdown must be called before deleting this. Call on the UI thread.
void Shutdown();
- // Only callable on the IO thread.
+ // Create a BackgroundSyncServiceImpl that is owned by this. Call on the UI
+ // thread.
+ void CreateService(mojo::InterfaceRequest<BackgroundSyncService> request);
+
+ // Called by BackgroundSyncServciceImpl objects so that they can
+ // be deleted. Call on the IO thread.
+ void ServiceHadConnectionError(BackgroundSyncServiceImpl* service);
+
+ // Call on the IO thread.
BackgroundSyncManager* background_sync_manager() const override;
protected:
@@ -38,11 +52,19 @@ class CONTENT_EXPORT BackgroundSyncContextImpl : public BackgroundSyncContext {
void CreateBackgroundSyncManager(
const scoped_refptr<ServiceWorkerContextWrapper>& context);
+ void CreateServiceOnIOThread(
+ mojo::InterfaceRequest<BackgroundSyncService> request);
+
void ShutdownOnIO();
// Only accessed on the IO thread.
scoped_ptr<BackgroundSyncManager> background_sync_manager_;
+ // The services are owned by this. They're either deleted
+ // during ShutdownOnIO or when the channel is closed via
+ // ServiceHadConnectionError. Only accessed on the IO thread.
+ std::set<BackgroundSyncServiceImpl*> services_;
+
DISALLOW_COPY_AND_ASSIGN(BackgroundSyncContextImpl);
};

Powered by Google App Engine
This is Rietveld 408576698