Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1283653004: Remove grab-bag includes of v8.h from full codegen. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from full codegen. R=yangguo@chromium.org Committed: https://crrev.com/66667d02407b122b9e156332423737aa494dcec9 Cr-Commit-Position: refs/heads/master@{#30130}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-11 13:05:41 UTC) #2
Yang
On 2015/08/11 13:05:41, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-12 10:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283653004/20001
5 years, 4 months ago (2015-08-12 10:53:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 11:12:58 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 11:13:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66667d02407b122b9e156332423737aa494dcec9
Cr-Commit-Position: refs/heads/master@{#30130}

Powered by Google App Engine
This is Rietveld 408576698