ui/base/l10n/l10n_util_collator.h - Issue 1283603002: Implement langageSettingsPrivate API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/l10n/l10n_util_collator.h

Issue 1283603002: Implement langageSettingsPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LanguageSettingsAPIIDLChanges

Patch Set: Fix const error in l10n_util_collator Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc ('K') | « chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/base/l10n/l10n_util_collator.h

diff --git a/ui/base/l10n/l10n_util_collator.h b/ui/base/l10n/l10n_util_collator.h

index a87784cf9d80908f2c3bcdb98a55089c9127ee3e..9b5322547b3ee719425d3293708c4d324c653157 100644

--- a/ui/base/l10n/l10n_util_collator.h

+++ b/ui/base/l10n/l10n_util_collator.h

@@ -94,7 +94,7 @@ class StringComparator : public std::binary_function<const Element&,

: collator_(collator) { }

// Returns true if lhs precedes rhs.

- bool operator()(const Element& lhs, const Element& rhs) {

+ bool operator()(const Element& lhs, const Element& rhs) const {

const base::string16& lhs_string_key = lhs.GetStringKey();

const base::string16& rhs_string_key = rhs.GetStringKey();

@@ -110,7 +110,7 @@ class StringComparator : public std::binary_function<const Element&,

template <>

UI_BASE_EXPORT inline bool StringComparator<base::string16>::operator()(

const base::string16& lhs,

- const base::string16& rhs) {

+ const base::string16& rhs) const {

// If we can not get collator instance for specified locale, just do simple

// string compare.

if (!collator_)