Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1283593005: Revert of Make run-tests.py warn when it's not testing anything (Closed)

Created:
5 years, 4 months ago by Michael Achenbach
Modified:
5 years, 4 months ago
Reviewers:
adamk, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make run-tests.py warn when it's not testing anything (patchset #1 id:1 of https://codereview.chromium.org/1283513003/ ) Reason for revert: Some bots that don't run tests (by design) don't return the test results json anymore which makes the infrastructure side fail now. Original issue's description: > Make run-tests.py warn when it's not testing anything > > I've often been confused by an "all passed" run of the test script > when it turned out that either all the tests I cared about were skipped > or, more likely, I mistyped the name(s) of the tests I wanted to run. > This patch aims to fix that (and gives a useful diagnostic for the > "all matched tests were skipped" case). > > R=machenbach@chromium.org > NOTRY=true > > Committed: https://crrev.com/1b1de2d221a0ed23e529e91bf9fa3dc287acb2ca > Cr-Commit-Position: refs/heads/master@{#30095} TBR=jkummerow@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3444bb6485036dd09635feca34b0a14050f4c374 Cr-Commit-Position: refs/heads/master@{#30097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M tools/run-tests.py View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Make run-tests.py warn when it's not testing anything
5 years, 4 months ago (2015-08-10 18:54:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283593005/1
5 years, 4 months ago (2015-08-10 18:54:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 18:54:58 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 18:55:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3444bb6485036dd09635feca34b0a14050f4c374
Cr-Commit-Position: refs/heads/master@{#30097}

Powered by Google App Engine
This is Rietveld 408576698