Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1283543007: Prevent a thread startup race in ScheduleWorkTest which causes a nullptr dereference of a message p… (Closed)

Created:
5 years, 4 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 4 months ago
Reviewers:
kinuko, danakj
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent a thread startup race in ScheduleWorkTest which causes a nullptr dereference of a message pump. Committed: https://crrev.com/7fc519fa5164f2eb7c718de2d0ed7500e11fc690 Cr-Commit-Position: refs/heads/master@{#342741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/message_loop/message_pump_perftest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
kinuko: I believe this was introduced in crrev.com/7f68f8735355c1c73557c3cfb294b441901fc31d
5 years, 4 months ago (2015-08-10 04:25:17 UTC) #2
kinuko
lgtm, thx for catching this!
5 years, 4 months ago (2015-08-10 04:58:03 UTC) #3
Anand Mistry (off Chromium)
danakj@chromium.org: For OWNERS.
5 years, 4 months ago (2015-08-10 05:04:11 UTC) #5
danakj
LGTM
5 years, 4 months ago (2015-08-10 18:08:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283543007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283543007/1
5 years, 4 months ago (2015-08-10 23:45:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 23:50:54 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 23:51:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fc519fa5164f2eb7c718de2d0ed7500e11fc690
Cr-Commit-Position: refs/heads/master@{#342741}

Powered by Google App Engine
This is Rietveld 408576698