Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1283543004: Linux: Depend on liberation-fonts package. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Depend on liberation-fonts package. Without these fonts, text in the built-in PDF viewer may not display correctly. BUG=369991 Committed: https://crrev.com/8f7b33b2f79917f2cb2f1df9f926575c070dbae1 Cr-Commit-Position: refs/heads/master@{#342645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/installer/linux/debian/build.sh View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/rpm/build.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Lei Zhang
Basing this off of: https://fedorahosted.org/liberation-fonts/ (see Distribution section) http://software.opensuse.org/package/liberation-fonts http://packages.ubuntu.com/trusty/fonts-liberation https://packages.debian.org/wheezy/fonts-liberation
5 years, 4 months ago (2015-08-08 00:54:42 UTC) #2
Michael Moss
lgtm (Also, would be nice if the CL summary mentioned something like "used by pdfviewer", ...
5 years, 4 months ago (2015-08-10 16:41:40 UTC) #3
Lei Zhang
On 2015/08/10 16:41:40, Michael Moss wrote: > lgtm > > (Also, would be nice if ...
5 years, 4 months ago (2015-08-10 17:29:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283543004/1
5 years, 4 months ago (2015-08-10 17:30:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 17:40:38 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f7b33b2f79917f2cb2f1df9f926575c070dbae1 Cr-Commit-Position: refs/heads/master@{#342645}
5 years, 4 months ago (2015-08-10 17:41:25 UTC) #8
Lei Zhang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1286743002/ by thestig@chromium.org. ...
5 years, 4 months ago (2015-08-11 16:37:18 UTC) #9
Michael Moss
On 2015/08/11 16:37:18, Lei Zhang wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 4 months ago (2015-08-11 16:40:38 UTC) #10
Lei Zhang
On 2015/08/11 16:40:38, Michael Moss wrote: > On 2015/08/11 16:37:18, Lei Zhang wrote: > > ...
5 years, 4 months ago (2015-08-11 16:51:04 UTC) #11
Lei Zhang
5 years, 4 months ago (2015-08-11 18:36:26 UTC) #12
Message was sent while issue was closed.
On 2015/08/11 16:51:04, Lei Zhang wrote:
> Sure. I'll re-examine the RPM situation and see if we can still do both.

(For those following along at home) The next try is
https://codereview.chromium.org/1274043004/

Powered by Google App Engine
This is Rietveld 408576698