[Android] Add a java.lang.System wrapper.

[Android] Add a java.lang.System wrapper.

Add a basic JNI wrapper for java.lang.System. Expose just the
getProperty() method, eliminating a deprecated __system_property_get
usage as well as a seperate System.getProperty wrapper.

The remaining uses of __system_property_get will be removed in
https://codereview.chromium.org/1236283002/.

BUG=392196, 392191
Committed: https://crrev.com/130c6bf9db16a69fca8488da8e15e978470e7e8b
Cr-Commit-Position: refs/heads/master@{#343245}

[jdduke (slow), 2015-08-07 22:14:18]

jdduke@chromium.org changed reviewers:
+ rmcilroy@chromium.org, ttuttle@chromium.org

[jdduke (slow), 2015-08-07 22:14:19]

+rmcilroy for base/android
+ttuttle for net/

[rmcilroy, 2015-08-10 12:36:05]

Thanks for doing this! I'd been meaning to get around to removing the
__system_property_get calls for a while. base/android lgtm.

[jdduke (slow), 2015-08-10 20:30:47]

jdduke@chromium.org changed reviewers:
+ danakj@chromium.org

[jdduke (slow), 2015-08-10 20:30:47]

+danakj for the rest of base/.

[danakj, 2015-08-10 20:35:37]

RS LGTM

[jdduke (slow), 2015-08-13 15:38:20]

jdduke@chromium.org changed reviewers:
+ davidben@chromium.org
- ttuttle@chromium.org

[jdduke (slow), 2015-08-13 15:38:21]

+davidben for net/, looks like ttuttle is OOO.

[davidben, 2015-08-13 15:53:43]

https://codereview.chromium.org/1283543003/diff/1/net/dns/dns_config_service_...
File net/dns/dns_config_service_posix.cc (left):

https://codereview.chromium.org/1283543003/diff/1/net/dns/dns_config_service_...
net/dns/dns_config_service_posix.cc:159: // are implementation details that may
disappear in future Android releases.
It seems part of this comment is still relevant. __system_property_get is gone,
but I think the "net.dns1" and "net.dns2" are still implementation details? At
least, I don't see them here:

http://developer.android.com/reference/java/lang/System.html#getProperty(java...

Is that correct?

[jdduke (slow), 2015-08-13 17:19:13]

https://codereview.chromium.org/1283543003/diff/1/net/dns/dns_config_service_...
File net/dns/dns_config_service_posix.cc (left):

https://codereview.chromium.org/1283543003/diff/1/net/dns/dns_config_service_...
net/dns/dns_config_service_posix.cc:159: // are implementation details that may
disappear in future Android releases.
On 2015/08/13 15:53:42, David Benjamin wrote:
> It seems part of this comment is still relevant. __system_property_get is
gone,
> but I think the "net.dns1" and "net.dns2" are still implementation details? At
> least, I don't see them here:
> 
>
http://developer.android.com/reference/java/lang/System.html#getProperty(java...
> 
> Is that correct?

You're absolutely right, I completely glossed over that. Restored that part of
the comment.

[davidben, 2015-08-13 17:21:12]

net lgtm

[jdduke (slow), 2015-08-13 17:33:47]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2015-08-13 17:33:47]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1283543003/#ps20001
(title: "Fix comment")

[commit-bot: I haz the power, 2015-08-13 17:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283543003/20001

[commit-bot: I haz the power, 2015-08-13 18:49:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-13 18:50:12]

Patchset 2 (id:??) landed as
https://crrev.com/130c6bf9db16a69fca8488da8e15e978470e7e8b
Cr-Commit-Position: refs/heads/master@{#343245}

[jdduke (slow), 2015-08-14 18:05:25]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1294883002/ by jdduke@chromium.org.

The reason for reverting is: This doesn't actually work..