Issue 128353002: Fixing WebRTC AEC dump tests on Android, disabling DTMF test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128353002: Fixing WebRTC AEC dump tests on Android, disabling DTMF test. (Closed)

Created:
6 years, 11 months ago by phoglund_chromium

Modified:
6 years, 11 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing WebRTC AEC dump tests on Android, disabling DTMF test. Seems the DTMF test didn't work well after all, when running with Opus. The AEC tests were broken because they didn't force iSAC. BUG=181069, 332016 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243685

Patch Set 1 #

Patch Set 2 : No longer double initializing the aec dump test server." #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
M	build/android/pylib/gtest/filter/content_browsertests_disabled	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/media/webrtc_aecdump_browsertest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/media/webrtc_browsertest.cc	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

phoglund_chromium

Feel free to check commit bit if you're happy with this.

6 years, 11 months ago (2014-01-08 14:50:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/128353002/220001

6 years, 11 months ago (2014-01-08 19:45:26 UTC) #3

Message was sent while issue was closed.

Change committed as 243685

Expand Messages | Collapse Messages