Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1283363003: Roll cacheinvalidation to include bug fixes for client release 20150720 (Closed)

Created:
5 years, 4 months ago by Colin Meek
Modified:
5 years, 4 months ago
Reviewers:
nyquist, Nicolas Zea
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_google3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll cacheinvalidation to include bug fixes for client release 20150720 BUG=496275, 505534 Committed: https://crrev.com/bfae1d5680d9305f913c03a901f802858734f9b5 Cr-Commit-Position: refs/heads/master@{#343779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M third_party/cacheinvalidation/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/ticl/android2/channel/AndroidMessageSenderService.java View 9 chunks +35 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
nyquist
lgtm
5 years, 4 months ago (2015-08-17 19:37:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283363003/1
5 years, 4 months ago (2015-08-17 19:38:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88997)
5 years, 4 months ago (2015-08-17 19:48:54 UTC) #6
Colin Meek
Hi Nicolas, Please take a look at this change which adds some defensive try...catch blocks ...
5 years, 4 months ago (2015-08-17 21:54:43 UTC) #8
Nicolas Zea
rs LGTM
5 years, 4 months ago (2015-08-18 00:10:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283363003/1
5 years, 4 months ago (2015-08-18 00:12:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 00:20:44 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 00:21:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfae1d5680d9305f913c03a901f802858734f9b5
Cr-Commit-Position: refs/heads/master@{#343779}

Powered by Google App Engine
This is Rietveld 408576698