Issue 1283323010: asan: Fix invalid memory access in UniversalExceptionRaise()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283323010: asan: Fix invalid memory access in UniversalExceptionRaise() (Closed)

Created:
5 years, 4 months ago by Mark Mentovai

Modified:
5 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

asan: Fix invalid memory access in UniversalExceptionRaise() TEST=crashpad_util_test ExcClientVariants.UniversalExceptionRaise R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6645a6924025f3455e4c6818cad3810b23e33cc1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	util/mach/exc_client_variants.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Robert Sesek

LGTM. Could have also changed .reserve() to .resize().

5 years, 4 months ago (2015-08-19 22:28:49 UTC) #3

Mark Mentovai

5 years, 4 months ago (2015-08-19 22:47:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6645a6924025f3455e4c6818cad3810b23e33cc1 (presubmit successful).