[interpreter]: Update BytecodeArrayBuilder register handling.

[interpreter]: Update BytecodeArrayBuilder register handling.

Modifies the BytecodeArrayBuilder to create register operands which are
negative. This reduces the number of instructions to access registers
by the interpreter and allows us to use positive register operands to
access parameter values.

Adds a Register class to keep register usage typesafe and simplify the
convertion to bytecode operand values.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/9b56924df20a2931e1d1fc7ee863fb266f527de0
Cr-Commit-Position: refs/heads/master@{#30151}

[rmcilroy, 2015-08-12 21:06:58]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-12 21:07:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283313003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283313003/20001

[commit-bot: I haz the power, 2015-08-12 21:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 21:09:17]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[rmcilroy, 2015-08-13 09:58:27]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-13 09:58:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283313003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283313003/40001

[rmcilroy, 2015-08-13 09:58:58]

rmcilroy@chromium.org changed reviewers:
+ oth@chromium.org

[rmcilroy, 2015-08-13 09:58:59]

Orion: could you take a look please? Thanks.

[oth, 2015-08-13 10:29:55]

lgtm. A couple of trivial comments, but fine.

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.h (right):

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.h:82: DCHECK_LE(index_,
kMaxRegisterIndex);
Probably worth having a lower bounds DCHECK too.

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecodes.h:113: std::ostream& operator<<(std::ostream& os,
const OperandType& operand_type);
Couldn't spot where this is used (?).

[commit-bot: I haz the power, 2015-08-13 10:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 10:30:12]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-08-13 10:44:22]

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.h (right):

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.h:82: DCHECK_LE(index_,
kMaxRegisterIndex);
On 2015/08/13 10:29:55, oth wrote:
> Probably worth having a lower bounds DCHECK too.

Done.

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecodes.h:113: std::ostream& operator<<(std::ostream& os,
const OperandType& operand_type);
On 2015/08/13 10:29:55, oth wrote:
> Couldn't spot where this is used (?).

It's required by DCHECK_EQ(x, OperandType::x). I just noticed that I didn't add
the DCHECK in this CL but in a subsequent CL, but given I'm touching these files
here I'd prefer just to keep in in this CL if that's OK with you?

[rmcilroy, 2015-08-13 10:44:54]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-08-13 10:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283313003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283313003/40001

[commit-bot: I haz the power, 2015-08-13 10:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 10:45:29]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[rmcilroy, 2015-08-13 10:51:35]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2015-08-13 10:51:36]

Micheal: could you stamp for committer/OWNERS please? Thanks.

[oth, 2015-08-13 11:08:43]

On 2015/08/13 10:44:22, rmcilroy wrote:

> It's required by DCHECK_EQ(x, OperandType::x). I just noticed that I didn't
add
> the DCHECK in this CL but in a subsequent CL, but given I'm touching these
files
> here I'd prefer just to keep in in this CL if that's OK with you?

Sounds fine.

[Michael Starzinger, 2015-08-13 11:11:45]

LGTM (rubber-stamped).

[rmcilroy, 2015-08-13 11:26:00]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-08-13 11:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283313003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283313003/40001

[commit-bot: I haz the power, 2015-08-13 11:27:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-13 11:28:09]

Patchset 3 (id:??) landed as
https://crrev.com/9b56924df20a2931e1d1fc7ee863fb266f527de0
Cr-Commit-Position: refs/heads/master@{#30151}